Fix end of previous line wrongly being included in highlight #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh sweet. Nice catch! |
|
ugh, looks like this does break some tests. These rules have been really tricky to get right :( |
icewind1991
force-pushed
the
span-line-start
branch
from
4d4c0fb
to
84f5433
Compare
|
Fixed the tests, the changes in highlight border box changed the frame width |
zkat
approved these changes
Sep 12, 2021
zkat
requested changes
Sep 12, 2021
|
Nevermind that part is my fault. Can you remove the diffs on the headers and I'll just merge this? And can you add a test that covers this corner case? |
icewind1991
force-pushed
the
span-line-start
branch
from
84f5433
to
717b6d5
Compare
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the highlight span starts at the very begining of a line, the highlight currently includes the line above
Before:
After: