This repository has been archived by the owner on Jul 6, 2019. It is now read-only.
Handle node_modules without package.json #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes running `npx` inside temporary projects (ones that have a `node_modules` but don't have a `package.json`). `getPrefix()` has useful cases: 1. Finds a path with a `package.json`, returns it. 2. Finds a path with a `node_modules`, returns it. 3. Finds nothing, returns the original path. Cases 1 and 2 return a path that's useful to `npx`, but case 3 doesn't. But, `localBinPath()` confused case 2 and 3 (by stating for a `package.json`), making `npx` only work with case 1. That's no good. This makes cases 1 and 2 distinct from case 3 (it just returns `false` now). And `localBinPath()` no longer has to do any stating to differentiate between paths and `false`, so it's happy. And now `npx` can run without a local `package.json`. Yay! Fixes zkat#104. Fixes babel/babel#4066 (comment).
jridgewell
force-pushed
the
without-package.json
branch
from
7282a7f
to
f8a7a1c
Compare
|
Ping @zkat, in case this slipped your radar. |
|
It did indeed slip my radar! |
zkat
approved these changes
Nov 6, 2017
|
Any plans for a release that would include this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes running
npxinside temporary projects (ones that have anode_modulesbut don't have apackage.json).getPrefix()has useful cases:package.json, returns it.node_modules, returns it.Cases 1 and 2 return a path that's useful to
npx, but case 3 doesn't.But,
localBinPath()confused case 2 and 3 (by stating for apackage.json), makingnpxonly work with case 1. That's no good.This makes cases 1 and 2 distinct from case 3 (it just returns
falsenow). And
localBinPath()no longer has to do any stating todifferentiate between paths and
false, so it's happy. And nownpxcan run without a local
package.json. Yay!Fixes #104.
Fixes babel/babel#4066 (comment).