Merge bb7ee6a into 400a9bf

package.json

@@ -11,7 +11,7 @@
     "preversion": "npm t",
     "postversion": "npm publish && git push --follow-tags",
     "pretest": "standard lib test *.js",
-    "test": "nyc -- tap test/*.js"
+    "test": "nyc -- tap -j8 test/*.js"
   },
   "repository": "https://github.com/zkat/pacote",
   "keywords": [
@@ -41,6 +41,6 @@
     "nyc": "^10.0.0",
     "rimraf": "^2.5.4",
     "standard": "^8.6.0",
-    "tap": "^8.0.1"
+    "tap": "^10.0.2"
   }
 }

test/registry.manifest.cache.js

@@ -38,6 +38,21 @@ var OPTS = {
   }
 }
 
+// DEBUG STUFF FOR ISAAC
+var signalExit = require('signal-exit')
+signalExit(function (code, signal) {
+  console.log('SE code=%j signal=%j process.exitCode=%j', code, signal, process.exitCode)
+})
+process.on('exit', function (code) {
+  console.log('PE code=%j process.exitCode=%j', code, process.exitCode)
+})
+process.reallyExit = (function (original) {
+  return function (code) {
+    console.log('reallyExit code=%j process.exitCode=%j', code, process.exitCode)
+    return original.apply(this, arguments)
+  }
+})(process.reallyExit)
+
 test('memoizes identical registry requests', function (t) {
   t.plan(2)
   var srv = tnock(t, OPTS.registry)
@@ -120,6 +135,10 @@ test('supports fetching from an optional cache', function (t) {
 test('expires stale request data')
 test('allows forcing use of cache when data stale')
 test('falls back to registry if cache entry is invalid JSON')
+// This test should prevent future footgunning if the caching logic changes
+// accidentally. Caching manifests themselves should be entirely the job of the
+// package fetcher.
+test('does not insert plain manifests into the cache')
 
 test('falls back to registry if cache entry missing', function (t) {
   var opts = {
@@ -136,8 +155,3 @@ test('falls back to registry if cache entry missing', function (t) {
     t.end()
   })
 })
-
-// This test should prevent future footgunning if the caching logic changes
-// accidentally. Caching manifests themselves should be entirely the job of the
-// package fetcher.
-test('does not insert plain manifests into the cache')

test/util/test-dir.js

@@ -7,13 +7,14 @@ var cacheDir = path.resolve(__dirname, '../cache')
 
 module.exports = testDir
 function testDir (filename) {
-  var dir = path.join(cacheDir, path.basename(filename, '.js'))
+  var base = path.basename(filename, '.js')
+  var dir = path.join(cacheDir, base)
   reset(dir)
   if (!process.env.KEEPCACHE) {
     tap.tearDown(function () {
       process.chdir(__dirname)
       try {
-        rimraf.sync(cacheDir)
+        rimraf.sync(dir)
       } catch (e) {
         if (process.platform !== 'win32') {
           throw e