fix(git): workaround for mississippi.finished intermitent failures (#144

)

Fixes: #143

lib/finalize-manifest.js

@@ -5,7 +5,7 @@ const BB = require('bluebird')
 const cacache = require('cacache')
 const cacheKey = require('./util/cache-key')
 const fetchFromManifest = require('./fetch').fromManifest
-const finished = BB.promisify(require('mississippi').finished)
+const finished = require('./util/finished')
 const minimatch = require('minimatch')
 const normalize = require('normalize-package-data')
 const optCheck = require('./util/opt-check')

lib/util/finished.js

@@ -0,0 +1,17 @@
+'use strict'
+
+const BB = require('bluebird')
+
+module.exports = function (child, hasExitCode = false) {
+  return BB.fromNode(function (cb) {
+    child.on('error', cb)
+    child.on(hasExitCode ? 'close' : 'end', function (exitCode) {
+      if (exitCode === undefined || exitCode === 0) {
+        cb()
+      } else {
+        let err = new Error('exited with error code: ' + exitCode)
+        cb(err)
+      }
+    })
+  })
+}

lib/util/git.js

@@ -6,7 +6,7 @@ const cp = require('child_process')
 const execFileAsync = BB.promisify(cp.execFile, {
   multiArgs: true
 })
-const finished = BB.promisify(require('mississippi').finished)
+const finished = require('./finished')
 const LRU = require('lru-cache')
 const optCheck = require('./opt-check')
 const osenv = require('osenv')
@@ -213,7 +213,7 @@ function spawnGit (gitArgs, gitOpts, opts) {
       child.stdout.on('data', d => { stdout += d })
       child.stderr.on('data', d => { stderr += d })
 
-      return finished(child).catch(err => {
+      return finished(child, true).catch(err => {
         if (shouldRetry(stderr)) {
           retry(err)
         } else {