registry: default to registry.npmjs.org if option is missing

zkat · Dec 5, 2016 · 7db952c · 7db952c
1 parent 3f3cd37
commit 7db952c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/lib/registry/pick-registry.js b/lib/registry/pick-registry.js
@@ -11,9 +11,5 @@ function pickRegistry (spec, opts, cb) {
     registry = opts.registry
   }
 
-  if (registry) {
-    cb(null, registry)
-  } else {
-    cb(new Error('registry option is required'))
-  }
+  cb(null, registry || 'https://registry.npmjs.org')
 }
diff --git a/test/manifest.registry.js b/test/manifest.registry.js
@@ -120,6 +120,17 @@ test('uses scope opt for registry lookup', function (t) {
   })
 })
 
+test('defaults to registry.npmjs.org if no option given', function (t) {
+  var server = nock('https://registry.npmjs.org')
+
+  server.get('/foo/1.2.3').once().reply(200, PKG)
+  manifest('foo@1.2.3', { registry: undefined }, function (err, pkg) {
+    if (err) { throw err }
+    t.deepEqual(pkg, PKG, 'used npm registry')
+    t.end()
+  })
+})
+
 test('supports scoped auth', function (t) {
   var TOKEN = 'deadbeef'
   var opts = {