fix(registry): encode username and password for auth

zkat · May 25, 2017 · c48b651 · c48b651
1 parent 5d36d94
commit c48b651
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/fetchers/registry/fetch.js b/lib/fetchers/registry/fetch.js
@@ -90,9 +90,9 @@ function getHeaders (uri, registry, opts) {
   if (shouldAuth && auth.token) {
     headers.authorization = `Bearer ${auth.token}`
   } else if (shouldAuth && auth.username && auth.password) {
-    const encoded = Buffer.from(
-      `${auth.username}:${auth.password}`, 'utf8'
-    ).toString('base64')
+    const username = encodeURIComponent(auth.username)
+    const password = encodeURIComponent(auth.password)
+    const encoded = Buffer.from(`${username}:${password}`).toString('base64')
     headers.authorization = `Basic ${encoded}`
   }
   return headers