Skip to content
This repository has been archived by the owner on Jul 3, 2019. It is now read-only.

fix(deps): move mkdirp and rimraf to dependencies #140

Merged
merged 1 commit into from
Feb 21, 2018
Merged

fix(deps): move mkdirp and rimraf to dependencies #140

merged 1 commit into from
Feb 21, 2018

Conversation

evocateur
Copy link
Contributor

This only hurts individuals on npm2, as both packages are transitive dependencies of many explicit dependencies already.

53899c7 added runtime require of mkdirp here
189cdd2 added runtime require of rimraf here

Fixes: #128

This only hurts individuals on npm2, as both packages are transitive
dependencies of many explicit dependencies already.

53899c7 added runtime require of mkdirp
189cdd2 added runtime require of rimraf

Fixes: #128
Copy link
Owner

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How embarrassing 🙈 Thanks for this patch! I wish we had a better way of sniffing out stuff like this :<

@zkat zkat merged commit 60d232f into zkat:latest Feb 21, 2018
zkat pushed a commit that referenced this pull request Feb 23, 2018
This only hurts individuals on npm2, as both packages are transitive
dependencies of many explicit dependencies already.

53899c7 added runtime require of mkdirp
189cdd2 added runtime require of rimraf

Fixes: #128
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants