This repository has been archived by the owner on Jul 3, 2019. It is now read-only.
Add tarball/extraction-related tests and fixes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
force-pushed
the
zkat/tarball-tests
branch
2 times, most recently
from
163e779
to
1834b3a
Compare
zkat
changed the title
zkat
force-pushed
the
zkat/tarball-tests
branch
from
1834b3a
to
bfe452c
Compare
zkat
force-pushed
the
zkat/tarball-tests
branch
2 times, most recently
from
afd8f24
to
b2221b0
Compare
This version of tar-fs makes it so extractions actually set uid/gid on dirs when running as root
The original code was written for node-tar, and it had some particular differences that I didn't spot until detailed tests were written for extract-stream. Things should work now.
zkat
force-pushed
the
zkat/tarball-tests
branch
from
b2221b0
to
c29eebd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also help boost coverage quite a bit :D
TODO
extract-streamregistry/tarball.js