Skip to content
This repository has been archived by the owner on Jul 3, 2019. It is now read-only.

fix(manifest): ETARGET when no packages match #55

Merged
merged 1 commit into from
Mar 6, 2017
Merged

fix(manifest): ETARGET when no packages match #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/registry/pick-manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function pickManifest (metadata, spec, opts) {
var err
return BB.fromNode(cb => {
if (!versions.length) {
err = new Error('Package has no valid versions.')
err = new Error(`No valid versions available for ${metadata.name}`)
err.code = 'ENOVERSIONS'
err.name = metadata.name
err.spec = spec
Expand Down Expand Up @@ -56,8 +56,8 @@ function pickManifest (metadata, spec, opts) {

var manifest = target && metadata.versions[target]
if (!manifest) {
err = new Error('No matching versions')
err.code = 'ENOENT'
err = new Error(`No matching version found for ${spec.name}@${spec.spec}`)
err.code = 'ETARGET'
err.name = metadata.name
err.spec = spec
err.versions = versions
Expand Down
4 changes: 2 additions & 2 deletions test/registry.pick-manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ test('skips any invalid version keys', t => {
() => { throw new Error('expected a failure') },
err => {
t.ok(err, 'got an error')
t.equal(err.code, 'ENOENT', 'no matching specs')
t.equal(err.code, 'ETARGET', 'no matching specs')
}
)
)
Expand All @@ -140,7 +140,7 @@ test('ENOENT if range does not match anything', t => {
() => { throw new Error('expected a failure') },
err => {
t.ok(err, 'got an error')
t.equal(err.code, 'ENOENT', 'useful error code returned.')
t.equal(err.code, 'ETARGET', 'useful error code returned.')
}
)
})
Expand Down