This repository has been archived by the owner on Jul 3, 2019. It is now read-only.
feat(directory): directory dep support #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strugee
pushed a commit
to strugee/pacote
that referenced
this pull request
Mar 9, 2021
Exposes `tar.c` options as a helper util. Useful for other apps that might want to replicate the same tarball creation from the npm cli in different contexts. Related to: npm/libnpmdiff#3 PR-URL: npm/pacote#68 Credit: @ruyadorno Close: zkat#68 Reviewed-by: @isaacs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
directory deps are a weird creature -- they require that npm actually go through some lifecycles and such. On top of that, npm/npm#15900 is changing the way directory deps work, to make them symlink.
This PR compromises by letting npm do the heavy lifting on this front. pacote will still be able to read local directory manifests for the CLI, but the CLI will have to do its own linking, do its own filtering so it doesn't ask pacote to extract a directory dep, and, if it wants to use pacote before the new behavior is out, pack its own tarball and then switch to local tarball mode for the rest of the process.