Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing zeroize for Gt #94

Closed
randombit opened this issue Sep 22, 2022 · 2 comments
Closed

Missing zeroize for Gt #94

randombit opened this issue Sep 22, 2022 · 2 comments

Comments

@randombit
Copy link

Zeroize is implemented for Fp12 but not for Gt - is this intentional or accidental?
randombit added a commit to dfinity/bls12_381 that referenced this issue Oct 3, 2022
@randombit
Implement Zeroize for Gt
94c1eb5 
This seems to be an omission in the upstream version
(see zkcrypto#94)
randombit added a commit to dfinity/bls12_381 that referenced this issue Oct 3, 2022
@randombit
Implement Zeroize for Gt
e87ca77 
This seems to be an omission in the upstream version
(see zkcrypto#94)
@randombit randombit mentioned this issue Oct 3, 2022
Merged
randombit added a commit to dfinity/bls12_381 that referenced this issue Oct 12, 2022
@randombit
Implement Zeroize for Gt (#4)
68852f2 
This seems to be an omission in the upstream version
(see zkcrypto#94)
@str4d
Copy link
Member

str4d commented Dec 7, 2022

Yes, this is accidental; it was just missed in the PR that added zeroize support. We have a Default impl for Gt, which is suitable for zeroization.

str4d added a commit that referenced this issue Dec 7, 2022
@str4d
Add zeroize support to Gt
89d665d 
Fixes #94.
@randombit
Copy link
Author

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@randombit @str4d