Bump to minimal MSRV required. #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to solve:
`error: package `rayon-core v1.11.0` cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.56.0`
This is due to the fact that:
```
❯ cargo tree -i rayon-core
rayon-core v1.11.0
└── rayon v1.7.0
└── criterion v0.3.6
[dev-dependencies]
└── bls12_381 v0.8.0
```
As you can see here, `criterion` depends on `rayon_core` with `^0.3`. After `rayon` moved up MSRV without bumping minor version, everything broke.
This bumps the MSRV to 1.59 fixing this issue. See: zkcrypto#112
After bumping to `1.59`, I saw the following:
`error: package `regex-syntax v0.7.2` cannot be built because it requires rustc 1.60.0 or newer, while the currently active rustc version is 1.59.0`
```
cargo tree -i regex-syntax
regex-syntax v0.7.2
└── regex v1.8.4
└── criterion v0.3.6
[dev-dependencies]
└── bls12_381 v0.8.0
```
It seems same thing happened as with `rayon_core`. Bumping to `1.60.0` solves all the issues.
chore: Bump MSRV to 1.60.0
It turns out that when `zeroize` and other features are set we get: `package `memchr v2.6.3` cannot be built because it requires rustc 1.61 or newer`. Therefore, this should be the last bump needed.
Closed
|
I checked in an MSRV-compatible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #112