Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use group crate for curve traits and wNAF #91

Closed
wants to merge 2 commits into from
Closed

Use group crate for curve traits and wNAF #91

wants to merge 2 commits into from

Conversation

str4d
Copy link
Member

@str4d str4d commented Jul 5, 2018

No description provided.

@str4d str4d mentioned this pull request Jul 6, 2018
Closed
@str4d str4d mentioned this pull request Nov 10, 2018
Merged
daira
daira approved these changes Jan 21, 2019
View reviewed changes
Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Eirik0
Eirik0 approved these changes Feb 6, 2019
View reviewed changes
Copy link

@Eirik0 Eirik0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Eirik0
Copy link

Eirik0 commented Feb 6, 2019

As a note, we get the following warning when compiling, but this also happens in master:

warning: unused `#[macro_use]` import
  --> src/lib.rs:15:1
   |
15 | #[macro_use]
   | ^^^^^^^^^^^^
   |
   = note: #[warn(unused_imports)] on by default

@str4d
Copy link
Member Author

str4d commented Apr 11, 2019

This was pulled into pairing in zcash/librustzcash#46 and will be upstreamed back to this repository once the pairing refactor (part of zcash/librustzcash#41) is complete.

@str4d str4d closed this Apr 11, 2019
ebfull pushed a commit that referenced this pull request Oct 8, 2019
@str4d
Fix pairing benchmarks
0de7279 
They were broken by #91 but went unnoticed because CI does not compile
the benchmarks, which requires the nightly toolchain.
str4d added a commit that referenced this pull request Aug 25, 2020
@str4d
Merge pull request #91 from str4d/upgrade-rand
05f098e 
Upgrade rand crate dependency to 0.7
str4d added a commit that referenced this pull request Aug 25, 2020
@str4d
Fix pairing benchmarks
b872e9f 
They were broken by #91 but went unnoticed because CI does not compile
the benchmarks, which requires the nightly toolchain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@Eirik0 Eirik0 Eirik0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@str4d @Eirik0 @daira