Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build and tests #40

Merged
merged 21 commits into from
Dec 19, 2023
Merged

fix build and tests #40

merged 21 commits into from
Dec 19, 2023

Conversation

bert0RM
Copy link
Collaborator

@bert0RM bert0RM commented Dec 13, 2023

No description provided.

Divide-By-0
Divide-By-0 requested changes Dec 19, 2023
View reviewed changes
packages/compiler/src/gen_circom.js Outdated Show resolved Hide resolved
@Divide-By-0
Copy link
Member

Divide-By-0 commented Dec 19, 2023 •
edited
Loading

In main, can you fix this (separate PR, once this is merged):

[build (linux/amd64)](https://github.com/zkemail/zk-regex/actions/runs/7252437710/job/19756902388#logs)
Started 23h 46m 46s ago
Requested labels: linux/amd64
Job defined at: zkemail/zk-regex/.github/workflows/publish.yaml@refs/heads/main
Waiting for a runner to pick up this job...

I think we should use runs-on instead for those machine-specific build tests.

@bert0RM bert0RM changed the title Rmacedo/fix build and tests fix build and tests Dec 19, 2023
@Divide-By-0 Divide-By-0 merged commit 895ec9f into main Dec 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Divide-By-0 Divide-By-0 Divide-By-0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bert0RM @Divide-By-0