Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests on main branch. #59

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Fix failing tests on main branch. #59

merged 2 commits into from
Feb 10, 2024

Conversation

SoraSuegami
Copy link
Contributor

I modifies the following things to fix failing tests on the main branch.

  • Replace regexToMinDFASpec and parseRegex functions in the packages/compiler/src/regex.ts with the implementations I wrote before because the current ones do not support negation regexes.
  • Add the default-features = false flag to the zk-regex-compiler dependency in the packages/apis/Cargo.toml.
  • Modify how to print the substring state transitions into the generated circom file to ensure that the output circom file is deterministic.

@SoraSuegami SoraSuegami merged commit b05ac3a into main Feb 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant