Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/example dylib 4 #106

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Feat/example dylib 4 #106

wants to merge 1 commit into from

Conversation

oskarth
Copy link
Collaborator

@oskarth oskarth commented Mar 12, 2024

Most dylib work has been merged already, see recent commits, cli/build_ios script, and example app.

With this config and mopro build --platforms=ios:

  1. dylib is included in a separate XCFramework
  2. Circuit dylib is copied into app bundle as part of build process
  3. Example works on real device detached from cable

Leaving as draft because I want to make sure integration works well for both dylib and non-dylib case. Might require user to manually add XCFramework in Xcode.

Screenshot 2024-03-12 at 16 10 38

I have not been able to test submitting to app store (Product -> Archive -> Validate/Upload) as I don't have a valid Apple Developer account, and won't be able to set it up properly quickly.

If someone can try it out and verify that it works that'd be much appreciated!

This PR replaces and improves on:

(Note that there might be some minor regressions for non-dylib case from previous commits due to cache etc.)

@oskarth
Copy link
Collaborator Author

oskarth commented Mar 13, 2024

Update: doesn't work for actual app store upload due to:

ITMS-90426: Invalid Swift Support - The SwiftSupport folder is missing. Rebuild your app using the current public (GM) version of Xcode and resubmit it.

Which is related to dylib. After trying many different things, we currently don't have a good way to approach this problem :/

https://forums.swift.org/t/swift-package-with-dynamic-libraries-leads-to-app-store-validation-error/66857/12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant