Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow for gather op with private/advice indices #454

Merged
merged 9 commits into from
Sep 4, 2023
Merged

feat: allow for gather op with private/advice indices #454

merged 9 commits into from
Sep 4, 2023

Conversation

alexander-camuto
Copy link
Collaborator

@alexander-camuto alexander-camuto commented Sep 3, 2023 •
edited

  • Allows for private / advice indices for indices in the gather op
  • This unlocks models like sklearns' decision tree -- which we convert to a nice pytorch graph using sk2torch
  • We add decision tree models from sklearn to the CI
  • The dynamic gather op also allows us to implement ops like argmax and argmin which we also add here !

Resolves #99

@alexander-camuto alexander-camuto marked this pull request as ready for review September 4, 2023 16:21
@alexander-camuto alexander-camuto merged commit 70c50d8 into main Sep 4, 2023
18 checks passed
@alexander-camuto alexander-camuto deleted the ac/private-gather branch September 4, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Random Forest / Decision Tree tensor op
1 participant
@alexander-camuto