Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI fixes #299

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Minor UI fixes #299

merged 1 commit into from
Feb 2, 2024

Conversation

0xSachinK
Copy link
Member

@0xSachinK 0xSachinK commented Feb 2, 2024

  • Fix grammatical mistake 11c062f
  • Hide Receive for an EOA f492d0b [Reverted]
  • Shallow rename to buy 9384cfe [Reverted]
    • I suggest we punt on this and instead do it along with swap page redesign
    • Can revert this commit.

Open Question:

  1. What is client/src/components/Toggle.tsx used for? I didn't rename the "Swap" to "Buy" there.

Copy link
Member

@asoong asoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Receive
</NavDropdownItem>
</ItemAndIconContainer>
{loginStatus != LoginStatus.EOA && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep this since we will be using it for any off ramper who has insufficient balance. There should be some way for them to navigate to this modal outside of that flow

@0xSachinK 0xSachinK merged commit 66127d8 into develop Feb 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants