Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scan QR code UX when camera access is turned off #10781

Closed
yahiheb opened this issue May 25, 2023 · 2 comments · Fixed by #10861
Closed

Improve scan QR code UX when camera access is turned off #10781

yahiheb opened this issue May 25, 2023 · 2 comments · Fixed by #10861
Assignees
Labels

Comments

@yahiheb
Copy link
Collaborator

yahiheb commented May 25, 2023

This is what a user gets when they try to scan a QR code but the camera access setting on their device is off.

First screen:

0

Second screen:

1

Note: this is on Windows 10.

@yahiheb yahiheb added the UI label May 25, 2023
@soosr
Copy link
Contributor

soosr commented Jun 8, 2023

The DeviceTypes is VideoForWindows in that case, While on the other hand the actual camera's type is DirectShow.

@YohDeadfall
Do we know what VideoForWindows as a type means? Can we simply filter the devices by type?
.Where(x => x.DeviceType != DeviceTypes.VideoForWindows)

@YohDeadfall
Copy link
Contributor

Sure, we can filter out that thing by doing a simple type check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants