Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add logic for jmultimap checking" #245

Merged
merged 3 commits into from Jan 9, 2023

Conversation

zktuong
Copy link
Owner

@zktuong zktuong commented Jan 9, 2023

Reverts #244

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #245 (435475a) into master (acb3959) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   82.22%   82.21%   -0.02%     
==========================================
  Files          47       47              
  Lines        8996     9018      +22     
==========================================
+ Hits         7397     7414      +17     
- Misses       1599     1604       +5     
Flag Coverage Δ
unittests 82.21% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandelion/preprocessing/_preprocessing.py 70.24% <100.00%> (+0.05%) ⬆️

@zktuong zktuong merged commit 08f4271 into master Jan 9, 2023
@zktuong zktuong deleted the revert-244-add-check-jmultimap-logic branch January 9, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant