-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Awkward to pandas #342
Awkward to pandas #342
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 82.84% 83.77% +0.93%
==========================================
Files 47 52 +5
Lines 8550 9062 +512
==========================================
+ Hits 7083 7592 +509
- Misses 1467 1470 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
@amoschoomy, forgot we also need to update the notebooks. Specifically https://github.com/zktuong/dandelion/blob/master/docs/notebooks/1c_dandelion_scirpy.ipynb |
right will do |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@zktuong updated notebook, have a look and removed those references to scirpy functions, let me know if anything needs to be changed/improved |
492184b
to
51e201b
Compare
…irpy, from_scirpy
51e201b
to
8003f04
Compare
PR is ready to merge pending final tests. Now the default behaviour is to convert to/from dandelion in mudata (with the option to return as anndata), using scirpy's @grst, should the default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please go with |
Created functions
to_ak
,from_ak
,from_scirpy
,to_scirpy
Functions are mostly adapted from scirpy.io modules
addresses #261