Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awkward to pandas #342

Merged
merged 41 commits into from
Jan 8, 2024
Merged

Awkward to pandas #342

merged 41 commits into from
Jan 8, 2024

Conversation

amoschoomy
Copy link
Collaborator

@amoschoomy amoschoomy commented Dec 21, 2023

Created functions to_ak, from_ak, from_scirpy, to_scirpy

Functions are mostly adapted from scirpy.io modules

addresses #261

@zktuong
Copy link
Owner

zktuong commented Dec 21, 2023

@grst

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83bd5fc) 82.84% compared to head (f426e6a) 83.77%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   82.84%   83.77%   +0.93%     
==========================================
  Files          47       52       +5     
  Lines        8550     9062     +512     
==========================================
+ Hits         7083     7592     +509     
- Misses       1467     1470       +3     
Flag Coverage Δ
unittests 83.77% <ø> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

@zktuong
Copy link
Owner

zktuong commented Dec 21, 2023

@amoschoomy, forgot we also need to update the notebooks. Specifically https://github.com/zktuong/dandelion/blob/master/docs/notebooks/1c_dandelion_scirpy.ipynb

@amoschoomy
Copy link
Collaborator Author

@amoschoomy, forgot we also need to update the notebooks. Specifically https://github.com/zktuong/dandelion/blob/master/docs/notebooks/1c_dandelion_scirpy.ipynb

right will do

dandelion/utilities/_io.py Show resolved Hide resolved
tests/test_tools_ak.py Outdated Show resolved Hide resolved
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@amoschoomy
Copy link
Collaborator Author

@amoschoomy, forgot we also need to update the notebooks. Specifically https://github.com/zktuong/dandelion/blob/master/docs/notebooks/1c_dandelion_scirpy.ipynb

right will do

@zktuong updated notebook, have a look and removed those references to scirpy functions, let me know if anything needs to be changed/improved

@zktuong
Copy link
Owner

zktuong commented Jan 8, 2024

PR is ready to merge pending final tests. Now the default behaviour is to convert to/from dandelion in mudata (with the option to return as anndata), using scirpy's read_airr functions internally.

@grst, should the default obsm key for gene expression be gex or rna? seems like muon is using rna while scirpy is using gex.

Copy link
Contributor

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grst
Copy link
Contributor

grst commented Jan 8, 2024

@grst, should the default obsm key for gene expression be gex or rna? seems like muon is using rna while scirpy is using gex.

Please go with gex to be consistent with scirpy. I wasn't aware of the muon convention at the time I implemented this.

@zktuong zktuong enabled auto-merge (squash) January 8, 2024 10:55
@zktuong zktuong merged commit 4e14e0f into zktuong:master Jan 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants