Presets per country #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add images from Wikipedia and StreetComplete - configure Webpack to serve images (and rename plugin for consistency) - fix and add Russian signs
|
Here is an example: |
- Introduce default/minimal preset set - Introduce URL param to change presets - Extend readme
tordans
force-pushed
the
presets-per-country
branch
from
2c838f8
to
c34de96
Compare
|
Need free and paid parking presets in default scope |
What would be good "international" icons for that? In #69 I don't see anything about those. In Germany, free parking is the (unfortunate) default and paid parking is signed only with a secondary sign like https://www.stvo2go.de/verkehrszeichen-parken-zusatzzeichen/#Parken_mit_Zusatzzeichen_mit_Parkschein. |
I think Russian signs are clear. For paid parking can search icon with moneys. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on top of #72. Only the second commit 2c838f8 is relevant here.
This will show the default/minimal editor presets (traffic signs) by default but allow to set the Russian presets by URL param.
The default only shows
no_stopping,no_parking.This would allow #44 to be merged back into master.
Possible next step: Add https://github.com/ideditor/country-coder to set the presets dynamically.