Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard repeated words #1553

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Discard repeated words #1553

merged 1 commit into from
Aug 7, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e9a48a2) 83.89% compared to head (c235242) 83.89%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1553   +/-   ##
========================================
  Coverage    83.89%   83.89%           
========================================
  Files          132      132           
  Lines        10843    10843           
  Branches      2801     2801           
========================================
  Hits          9097     9097           
  Misses        1047     1047           
  Partials       699      699           
Flag Coverage Δ
macos_clang 42.97% <ø> (ø)
macos_gcc 73.61% <ø> (ø)
ubuntu_clang 82.50% <ø> (ø)
ubuntu_clang_debug 82.14% <ø> (ø)
ubuntu_clang_inflate_allow_invalid_dist 82.15% <ø> (ø)
ubuntu_clang_inflate_strict 82.49% <ø> (+0.22%) ⬆️
ubuntu_clang_mmap 82.82% <ø> (ø)
ubuntu_clang_pigz 13.96% <ø> (ø)
ubuntu_clang_pigz_no_optim 11.51% <ø> (ø)
ubuntu_clang_pigz_no_threads 13.78% <ø> (+0.05%) ⬆️
ubuntu_clang_reduced_mem 82.67% <ø> (-0.23%) ⬇️
ubuntu_clang_toolchain_riscv ∅ <ø> (∅)
ubuntu_gcc 75.30% <ø> (ø)
ubuntu_gcc_aarch64 77.40% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 75.64% <ø> (-0.02%) ⬇️
ubuntu_gcc_aarch64_no_acle 76.16% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 76.16% <ø> (ø)
ubuntu_gcc_armhf 77.47% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 75.60% <ø> (ø)
ubuntu_gcc_armhf_no_acle 77.42% <ø> (ø)
ubuntu_gcc_armhf_no_neon 77.32% <ø> (ø)
ubuntu_gcc_armsf 74.65% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 74.09% <ø> (ø)
ubuntu_gcc_benchmark 73.41% <ø> (-0.17%) ⬇️
ubuntu_gcc_compat_no_opt 76.85% <ø> (ø)
ubuntu_gcc_compat_sprefix 73.57% <ø> (-0.16%) ⬇️
ubuntu_gcc_m32 73.23% <ø> (-0.16%) ⬇️
ubuntu_gcc_mingw_i686 73.65% <ø> (+0.15%) ⬆️
ubuntu_gcc_mingw_x86_64 73.51% <ø> (ø)
ubuntu_gcc_mips 74.97% <ø> (ø)
ubuntu_gcc_mips64 74.98% <ø> (ø)
ubuntu_gcc_no_avx2 74.28% <ø> (ø)
ubuntu_gcc_no_ctz 74.65% <ø> (ø)
ubuntu_gcc_no_ctzll 74.64% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 74.28% <ø> (+0.06%) ⬆️
ubuntu_gcc_no_sse2 74.48% <ø> (-0.06%) ⬇️
ubuntu_gcc_no_sse42 74.73% <ø> (+0.55%) ⬆️
ubuntu_gcc_o1 74.18% <ø> (ø)
ubuntu_gcc_osb ∅ <ø> (∅)
ubuntu_gcc_pigz 38.17% <ø> (+0.02%) ⬆️
ubuntu_gcc_pigz_aarch64 39.02% <ø> (+0.02%) ⬆️
ubuntu_gcc_ppc 73.92% <ø> (ø)
ubuntu_gcc_ppc64 74.36% <ø> (ø)
ubuntu_gcc_ppc64_power9 74.53% <ø> (ø)
ubuntu_gcc_ppc64le 74.43% <ø> (ø)
ubuntu_gcc_ppc64le_novsx 74.75% <ø> (ø)
ubuntu_gcc_ppc64le_power9 74.31% <ø> (ø)
ubuntu_gcc_ppc_no_power8 74.63% <ø> (ø)
ubuntu_gcc_s390x 74.80% <ø> (ø)
ubuntu_gcc_s390x_dfltcc 71.92% <ø> (ø)
ubuntu_gcc_s390x_dfltcc_compat 73.98% <ø> (ø)
ubuntu_gcc_s390x_no_crc32 74.59% <ø> (ø)
ubuntu_gcc_sparc64 74.79% <ø> (ø)
ubuntu_gcc_sprefix 73.24% <ø> (ø)
win64_gcc 73.95% <ø> (ø)
win64_gcc_compat_no_opt 74.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
arch/x86/adler32_ssse3.c 100.00% <ø> (ø)
insert_string_tpl.h 100.00% <ø> (ø)
test/fuzz/fuzzer_minigzip.c 50.38% <ø> (ø)
test/minigzip.c 57.86% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dead2
Copy link
Member

Dead2 commented Aug 7, 2023

@DimitriPapadopoulos Thanks for the fixes.
Tip for next time though; since all these are cleanups, and each commit is small and has uncontroversial changes, it would be easier to have a single PR but with separate commits for each type of change. 😉

@Dead2 Dead2 merged commit 73bbb54 into zlib-ng:develop Aug 7, 2023
136 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the repeated_words branch August 7, 2023 06:35
@Dead2 Dead2 mentioned this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants