Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose gists "public" attribute to allow secret gists #2

Closed
unode opened this issue Jul 18, 2015 · 6 comments
Closed

Expose gists "public" attribute to allow secret gists #2

unode opened this issue Jul 18, 2015 · 6 comments

Comments

@unode
Copy link
Contributor

unode commented Jul 18, 2015

Hi Bo,

I'd like to be able to default to secret gists when using the github service.
I see in the API docs that "public:false" is the default and I also see in wgetpaste that "public: true" is hardcoded in the gist JSON request. Is there any way this could be exposed so I could customize it from a config file?

Thanks

@zlin
Copy link
Owner

zlin commented Aug 27, 2015

I'd certainly take a patch.

I guess the most simplistic would be making it use public: ${PUBLIC_gists:-true}. Or you can suggest something more sophisticated.

@unode
Copy link
Contributor Author

unode commented Mar 6, 2016

Took a while :)

https://gist.github.com/Unode/7e65f53bb152485d038b

Uploaded using the patch itself.

@zlin
Copy link
Owner

zlin commented Mar 7, 2016

I clearly haven't quite understood this commenting system...

Took a while :)

Yeah, I'm finally caught up on reading mails again. ;)

If I should fall behind again, IRC on freenode will probably remain the quickest way to gain my attention.

https://gist.github.com/Unode/7e65f53bb152485d038b

Please use [[ ... || .. ]] rather than [[ ... ]] || [[ ... ]] on line 38.

Looks good otherwise.

@unode
Copy link
Contributor Author

unode commented Mar 7, 2016

Updated. Same address.

@zlin zlin closed this as completed Mar 8, 2016
@zlin
Copy link
Owner

zlin commented Mar 8, 2016

Alright, it's in version 2.27

@unode
Copy link
Contributor Author

unode commented Mar 8, 2016

Cool, cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants