ignore return value of [@@dispose]() method when hint is `async-dis…

…pose` tc39/proposal-explicit-resource-management#180
zloirock · Jul 19, 2023 · 0d62693 · 0d62693
1 parent cb0db7c
commit 0d62693
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,7 @@
     - `AsyncIterator.prototype[@@asyncDispose]`
   - Moved back into [the initial proposal](https://github.com/tc39/proposal-explicit-resource-management) -> moved to stage 3, [proposal-explicit-resource-management/154](https://github.com/tc39/proposal-explicit-resource-management/pull/154)
   - Added `/actual/` namespace entries, disabled forced replacement
+  - Ignore return value of `[@@dispose]()` method when hint is `async-dispose`, [proposal-explicit-resource-management/180](https://github.com/tc39/proposal-explicit-resource-management/pull/180)
 - Added [`DataView` get / set `Uint8Clamped` methods stage 1 proposal](https://github.com/tc39/proposal-dataview-get-set-uint8clamped):
   - Methods:
     - `DataView.prototype.getUint8Clamped`

diff --git a/packages/core-js/internals/add-disposable-resource.js b/packages/core-js/internals/add-disposable-resource.js
@@ -1,4 +1,5 @@
 'use strict';
+var call = require('../internals/function-call');
 var uncurryThis = require('../internals/function-uncurry-this');
 var bind = require('../internals/function-bind-context');
 var anObject = require('../internals/an-object');
@@ -13,7 +14,12 @@ var push = uncurryThis([].push);
 
 var getDisposeMethod = function (V, hint) {
   if (hint == 'async-dispose') {
-    return getMethod(V, ASYNC_DISPOSE) || getMethod(V, DISPOSE);
+    var method = getMethod(V, ASYNC_DISPOSE);
+    if (method !== undefined) return method;
+    method = getMethod(V, DISPOSE);
+    return function () {
+      call(method, this);
+    };
   } return getMethod(V, DISPOSE);
 };