Skip to content

Commit

Permalink
use native parseInt in esnext.number.from-string for untangling
Browse files Browse the repository at this point in the history
  • Loading branch information
zloirock committed Oct 31, 2023
1 parent 7cbd6b5 commit cca57be
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/core-js/modules/esnext.number.from-string.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
var $ = require('../internals/export');
var uncurryThis = require('../internals/function-uncurry-this');
var toIntegerOrInfinity = require('../internals/to-integer-or-infinity');
var parseInt = require('../internals/number-parse-int');

var INVALID_NUMBER_REPRESENTATION = 'Invalid number representation';
var INVALID_RADIX = 'Invalid radix';
var $RangeError = RangeError;
var $SyntaxError = SyntaxError;
var $TypeError = TypeError;
var $parseInt = parseInt;
var pow = Math.pow;
var valid = /^[\d.a-z]+$/;
var charAt = uncurryThis(''.charAt);
Expand All @@ -33,8 +33,8 @@ $({ target: 'Number', stat: true, forced: true }, {
if (R < 2 || R > 36) throw new $RangeError(INVALID_RADIX);
if (!exec(valid, string)) throw new $SyntaxError(INVALID_NUMBER_REPRESENTATION);
var parts = split(string, '.');
var mathNum = parseInt(parts[0], R);
if (parts.length > 1) mathNum += parseInt(parts[1], R) / pow(R, parts[1].length);
var mathNum = $parseInt(parts[0], R);
if (parts.length > 1) mathNum += $parseInt(parts[1], R) / pow(R, parts[1].length);
if (numberToString(mathNum, R) !== string) throw new $SyntaxError(INVALID_NUMBER_REPRESENTATION);
return sign * mathNum;
}
Expand Down

0 comments on commit cca57be

Please sign in to comment.