-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iframe.src = 'javascript:'; breaking JS parsers #475
Comments
Does |
it does not. any value other that '' seems to be treated as a relative path which the parser thinks in an asset. below is the error message from the parser. Make sure the filenames of all files in your .ZIP file are exactly the same as the name listed in the reference file. For example, if one of the files in your .ZIP file is called path/to/example/asset, but in your HTML file you reference path/to/example/asset2, AdWords will not be able to to find the correct file. To fix the issue, compare the filename listed above with every file in your HTML5 code. If it is not exactly the same, correct the reference. More details: |
Let's split it into some parts. I hope it will help. |
the error is still there just slightly different. Make sure the filenames of all files in your .ZIP file are exactly the same as the name listed in the reference file. For example, if one of the files in your .ZIP file is called path/to/example/asset, but in your HTML file you reference path/to/example/asset2, AdWords will not be able to to find the correct file. To fix the issue, compare the filename listed above with every file in your HTML5 code. If it is not exactly the same, correct the reference. More details: |
seems to work. |
This line is creating JS that won't pass a parser. I am uploading JS files to DoubleClick and this line is causing the units to throw errors. iframe.src = ''; does not seem to cause a problem. is it necessary to have the 'javascript:' part in there?
https://github.com/zloirock/core-js/blob/master/packages/core-js/internals/object-create.js
The text was updated successfully, but these errors were encountered: