IE11 Out of stack space

[kane-mason]

We use core js in a games engine and recently updated from 2.5.7 to 2.6.0 but are facing an "Out of stack space" error happening in Internet Explorer 11 (Build 11.805.17763.0 on Windows 10). See picture below of stack trace:

[zloirock]

core-js@2.6.0 is an obsolete version and no longer supported. Anyway, without a reproducible example, I can't say anything.

[kane-mason]

Well the same error happens on all versions after 2.5.7, even the latest 3.3.6, i thought providing the version number where it started happening would help identify the change that introduced it. Unfortunately IE11s poor debugging tools i am having a hard time locating exactly where it happens. Will try get some more info, otherwise could share a link with you privately

[mikea]

I'm having the same issue in IE11 while trying to upgrade to corejs3. Trying to understand what happens (ie11 debugging tools are terrible)

[mikea]

After lots of debugging it seems that first stack overflow happens in dom-collections.iterable:

https://github.com/zloirock/core-js/blob/master/packages/core-js/modules/web.dom-collections.iterator.js#L17

Happens on the first loop iteration with COLLECTION_NAME==="CSSRuleList"
which gets infinite loop in es.symbol:

https://github.com/zloirock/core-js/blob/master/packages/core-js/modules/es.symbol.js#L170

@zloirock @kane-mason

[zloirock]

That looks like a conflict with another Symbol polyfill (not 100%). core-js well-known symbols, like @@iterator on CSSRuleList haven't this setters-related logic.

[mikea]

I don’t think we use another polyfill. Maybe it is sneaking in through some dependency. Any suggestion where to start looking? Best regards, Mike

…

________________________________ From: Denis Pushkarev <notifications@github.com> Sent: Monday, November 4, 2019 17:36 To: zloirock/core-js Cc: Mike Aizatsky; Comment Subject: Re: [zloirock/core-js] IE11 Out of stack space (#686) That looks like a conflict with another Symbol polyfill (not 100%). core-js well-known symbols, like @@iterator on CSSRuleList haven't this setters-related logic. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#686?email_source=notifications&email_token=AAAAZJBYJUX3WBW4OZIODGLQSDEZHA5CNFSM4JH2L4G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDBJVRI#issuecomment-549624517>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAAAZJENFSV5C7PUBG4W4Z3QSDEZHANCNFSM4JH2L4GQ>.

[zloirock]

Create a reproducible example? -)

[mikea]

Yeah, that would be great. But to do that I need to find who’s messing with symbol in our very non-trivial typescript codebase. :( Denis, if your theory is correct then there should be observable artifacts of another polyfill. Which prototypes/globals should I check? There have to be some functions registered. Maybe I can track them down by their source code. Best regards, Mike

…

________________________________ From: Denis Pushkarev <notifications@github.com> Sent: Monday, November 4, 2019 17:56 To: zloirock/core-js Cc: Mike Aizatsky; Comment Subject: Re: [zloirock/core-js] IE11 Out of stack space (#686) Create a reproducible example? -) — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#686?email_source=notifications&email_token=AAAAZJCHJL3NOBDP35TSH2LQSDHDLA5CNFSM4JH2L4G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDBKWQA#issuecomment-549628736>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAAAZJHESXB6KVMJCY2464TQSDHDLANCNFSM4JH2L4GQ>.

[zloirock]

It's "another polyfill" case only if it happens here. It looks like #163. Well-known core-js symbols are protected from it since they don't add setters, but in your stack trace, we see the symbol polyfill setters.

[mikea]

@zloirock thanks, I'll try to dig through those bugs and see if it applies to us.
For what it is worth, I believe we have 0 explicit usages of Symbol in our code base. Looks like usage is coming from core-js itself.

[kane-mason]

Ok, so got to the bottom of our issue. We have a game wrapper bundle that gets injected moments before the game bundle, and it is also using core-js, but a much older version 1.2.5. Best i can tell is the our newer core-js comes along and completes some partial polyfills and does some new ones, but the combination of the older and newer core-js just won't work. To be expected really

[mikea]

I need to double-check things, but it seems that bad symbol comes from object.assign which comes from babel:

├─┬ @babel/preset-env@7.6.3
│ └─┬ @babel/plugin-transform-modules-amd@7.5.0
│   └─┬ babel-plugin-dynamic-import-node@2.3.0
│     └── object.assign@4.1.0  deduped

[mikea]

And related object.assign issue could be: ljharb/object.assign#17

[zloirock]

@mikea the mentioned issue is not related to this recursion.

[zloirock]

Could you show me your babel config? Something like that possible in some incorrect cases usage of both - global and pure versions of core-js together.

[mikea]

Here it is:

const presets = [
  [
    "@babel/preset-env",
    {
      targets: {
        browsers: ["last 2 versions", "ie >= 10", "chrome >= 41", "safari >= 9"],
      },
    },
  ],
  "@babel/preset-typescript",
  "@babel/preset-react",
];

const plugins = [
  [
    "@babel/plugin-transform-runtime",
    {
      corejs: 3,
      absoluteRuntime: true,
    },
  ],

  // Babel has killed stages: https://babeljs.io/blog/2018/07/27/removing-babels-stage-presets
  // Stage 2
  [
    "@babel/plugin-proposal-decorators",
    {
      legacy: true,
    },
  ],
  "@babel/plugin-proposal-function-sent",
  "@babel/plugin-proposal-export-namespace-from",
  "@babel/plugin-proposal-numeric-separator",
  "@babel/plugin-proposal-throw-expressions",

  // Stage 3
  "@babel/plugin-syntax-dynamic-import",
  "@babel/plugin-syntax-import-meta",
  [
    "@babel/plugin-proposal-class-properties",
    {
      loose: false,
    },
  ],
  "@babel/plugin-proposal-json-strings",

  // see https://github.com/babel/babel/issues/8244
  // we use custom namespaces in DomJSX
  "babel-plugin-typescript-strip-namespaces",
];

module.exports = {
  sourceType: "unambiguous",
  presets,
  plugins,
};

[zloirock]

@mikea so, in your case, the error comes from core-js or core-js-pure?

[zloirock]

Could you check it with the current version?

[zloirock]

Closed due to lack of response. Most likely, it was fixed after adding this workaround.

[tonoslav]

@zloirock
Just to ask, why there is all those "Symbol()..." object attributes added to everyobject I use in IE?

[zloirock]

@tonoslav we should hide polyfilled symbols from almost all ways of iteration includes for-in loop, adding setters to Object.prototype is the only way to make it work properly.