Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE/Edge missing in compat data #756

Closed
kroofy opened this issue Jan 23, 2020 · 2 comments
Closed

IE/Edge missing in compat data #756

kroofy opened this issue Jan 23, 2020 · 2 comments

Comments

@kroofy
Copy link

kroofy commented Jan 23, 2020

While browsing thru https://github.com/zloirock/core-js/blob/master/packages/core-js-compat/src/data.js

I noticed that es.string.search (browser compat) and es.string.replace among others are missing IE and Edge versions. Is this intentional or would it be welcomed by the project to have a PR submitted to add compat data for IE and Edge related polyfills? I would be happy to help it that's the case.

@davidmerrique
Copy link

I also noticed that Edge is missing from a few other things, such as es.promise, es.object.assign (https://kangax.github.io/compat-table/es6/#test-Promise)

@slowcheetah
Copy link
Contributor

@kroofy by modern standards, es.string.replace & es.string.search should refer to well-known symbols. IE deviates from these standards and some others. Therefore, these methods should be polyfilled.

@davidmerrique see #761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants