Push an empty string when testing whether [].length is writable #1314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the current version of Chrome (v119.0.6045.199, on macOS 14.1.1) is not throwing the expected error when calling
push
with no arguments.This leads to
Array.prototype.push
being polyfilled more than expected, affecting performance.Firefox and Safari throw the expected error both with and without this change, although the message is slightly different in Firefox when pushing an empty string.
Firefox 120.0.1:
Safari 17.1:
I haven't tested with any other browsers or versions.
It's possible that this does actually indicate a case where
Array.prototype.push
needs to be polyfilled, of course, in which case feel free to close this PR.