Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata update for dropwizard project #2

Closed
zloster opened this issue Mar 22, 2017 · 2 comments
Closed

Metadata update for dropwizard project #2

zloster opened this issue Mar 22, 2017 · 2 comments
Assignees
@zloster
Milestone
Dropwizard JDBI i...

Comments

@zloster
Copy link
Owner

zloster commented Mar 22, 2017 •
edited
Loading

Update the benchmark_config.json to have correct versus data.
For example:

jdbi-postgres is configured to be compared with "versus": "servlet-raw-postgres"

The actual name must be verified by checking the JSON configuration of the project you want to compare with.
MySQL test should compare against servlet-raw. servlet is the default name but there are no DB tests and we need to point the config with the MySQL code which is servlet-raw.

Update:
We need to break up things as the servlet's benchmark_config.json. There are 3 (three) parts. One for the plaintext and JSON and 2 (two) for the MySQL and PostgreSQL tests. I'm not sure what should be the base comparison for MongoDB tests. Maybe MySQL.
@zloster
Copy link
Owner Author

zloster commented Apr 3, 2017 •
edited
Loading

Changes implemented, local test in progress...
(https://www.techempower.com/benchmarks/#section=test for results viewing)

@zloster zloster self-assigned this Apr 4, 2017
@zloster
Copy link
Owner Author

zloster commented Apr 4, 2017

It seems that there is no way to provide the test metadata to the custom results viewer i.e. can't play with versus field in the benchmark_config.json and see what will happen in the browser. So no easy way to verify how the things will look.

@zloster zloster closed this as completed Apr 4, 2017
zloster pushed a commit that referenced this issue Jan 30, 2018
@michaelhixson @NateBrady23
Try to fix PHP/hhvm tests by working around an issue with SET NAMES (T…
903997f 
…echEmpower#3220)

I think we are running into this problem:

  facebook/hhvm#8111

We don't solve that problem, but we avoid it by specifying utf8 in a
different fashion.  I also took the opportunity to use the "TFB-database"
hostname instead of the DBHOST environment variable because it's simpler
that way.

Here are the steps I took in a local TFB environment that make me think
we're running into the same issue as that GitHub issue:

 - Run toolset/run-tests.py --mode verify --test hvm, see that it fails
   all tests with error messages that look like the application server
   simply isn't there
 - Enable logging in PHP/hhvm/deploy/config.hdf (basically copy the
   "Log" section over from config-debug.hdf), run the test again
 - Look at the log file it spit out, PHP/hhvm/error.log, notice messages
   like this:

    Core dumped: Segmentation fault
    Stack trace in /tmp/stacktrace.28653.log

 - /tmp is cleared by the TFB toolset each run, so I comment out that
   part of benchmarker.py that clears /tmp
 - Run the test again, look at the stacktrace file in /tmp, notice a
   stack trace referring to our implementation code like this:

    #0  PDO->__construct() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/once.php.inc:14]
    #1  Benchmark->setup_db() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/once.php.inc:31]
    #2  Benchmark->bench_db() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/db.php:10]
    #3  main() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/db.php:13]

 - Google a bit, come across a GitHub issue talking about a similar
   problem when they used "SET NAMES"
 - Comment the part of PHP/hhvm/once.php.inc that uses SET NAMES, run
   test again and it worked, except for fortunes which failed because of
   character encoding problems
 - Google for a different way to specify utf8 in the PDO constructor,
   try it again, all tests pass locally
zloster pushed a commit that referenced this issue Feb 7, 2018
@michaelhixson
Try to fix PHP/hhvm tests by working around an issue with SET NAMES (T…
8df1643 
…echEmpower#3220)

I think we are running into this problem:

  facebook/hhvm#8111

We don't solve that problem, but we avoid it by specifying utf8 in a
different fashion.  I also took the opportunity to use the "TFB-database"
hostname instead of the DBHOST environment variable because it's simpler
that way.

Here are the steps I took in a local TFB environment that make me think
we're running into the same issue as that GitHub issue:

 - Run toolset/run-tests.py --mode verify --test hvm, see that it fails
   all tests with error messages that look like the application server
   simply isn't there
 - Enable logging in PHP/hhvm/deploy/config.hdf (basically copy the
   "Log" section over from config-debug.hdf), run the test again
 - Look at the log file it spit out, PHP/hhvm/error.log, notice messages
   like this:

    Core dumped: Segmentation fault
    Stack trace in /tmp/stacktrace.28653.log

 - /tmp is cleared by the TFB toolset each run, so I comment out that
   part of benchmarker.py that clears /tmp
 - Run the test again, look at the stacktrace file in /tmp, notice a
   stack trace referring to our implementation code like this:

    #0  PDO->__construct() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/once.php.inc:14]
    #1  Benchmark->setup_db() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/once.php.inc:31]
    #2  Benchmark->bench_db() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/db.php:10]
    #3  main() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/db.php:13]

 - Google a bit, come across a GitHub issue talking about a similar
   problem when they used "SET NAMES"
 - Comment the part of PHP/hhvm/once.php.inc that uses SET NAMES, run
   test again and it worked, except for fortunes which failed because of
   character encoding problems
 - Google for a different way to specify utf8 in the PDO constructor,
   try it again, all tests pass locally
zloster pushed a commit that referenced this issue Oct 2, 2018
@msmith-techempower @NateBrady23
[ci skip] Attempt #2 at .gitattributes (TechEmpower#3564)
bb783a0
zloster pushed a commit that referenced this issue Oct 2, 2018
@michaelhixson @NateBrady23
Fix an uncaught exception during dart startup (TechEmpower#3640)
04dd98d 
Here's an example of the error output from before this change:

Unhandled exception:
Bad state: Stream was already listened to
#0      _RawServerSocket.listen (dart:io-patch/socket_patch.dart:1106)
#1      new _ForwardingStreamSubscription (dart:async/stream_pipe.dart:123)
#2      _ForwardingStream._createSubscription (dart:async/stream_pipe.dart:91)
#3      _ForwardingStream.listen (dart:async/stream_pipe.dart:86)
#4      _ServerSocket.listen (dart:io-patch/socket_patch.dart:1351)
#5      _HttpServer.listen (dart:io/http_impl.dart:2278)
#6      _startServer.<anonymous closure> (file:///server.dart:88:12)
#7      _RootZone.runUnary (dart:async/zone.dart:1371)
#8      _FutureListener.handleValue (dart:async/future_impl.dart:129)
#9      _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:636)
#10     _Future._propagateToListeners (dart:async/future_impl.dart:665)
#11     _Future._completeWithValue (dart:async/future_impl.dart:478)
#12     Future.wait.<anonymous closure> (dart:async/future.dart:362)
#13     _RootZone.runUnary (dart:async/zone.dart:1371)
#14     _FutureListener.handleValue (dart:async/future_impl.dart:129)
#15     _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:636)
#16     _Future._propagateToListeners (dart:async/future_impl.dart:665)
#17     _Future._completeWithValue (dart:async/future_impl.dart:478)
#18     Future.wait.<anonymous closure> (dart:async/future.dart:362)
#19     _RootZone.runUnary (dart:async/zone.dart:1371)
#20     _FutureListener.handleValue (dart:async/future_impl.dart:129)
#21     _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:636)
#22     _Future._propagateToListeners (dart:async/future_impl.dart:665)
#23     _Future._completeWithValue (dart:async/future_impl.dart:478)
#24     _Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:510)
#25     _microtaskLoop (dart:async/schedule_microtask.dart:41)
#26     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)
#27     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:99)
#28     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:152)
zloster pushed a commit that referenced this issue Oct 2, 2018
@greenlaw110 @NateBrady23
[ci fw-only Java/act] Act: tune #2 for pgsql update tests (TechEmpowe…
9b0368d 
…r#3850)

* [ci fw-only Java/act] Act: tune #2 for pgsql update tests

* use HikariCP with Eclipselink; use druid with ebean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zloster zloster

Labels
None yet
Projects
None yet
Milestone
Dropwizard JDBI implementation
Development

No branches or pull requests
1 participant
@zloster