This repository has been archived by the owner on Jul 8, 2021. It is now read-only.
zgrab: log target address/port on panic #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic back out to the caller
|
oh that's awesome! I didn't know you could do that in golang! |
dadrian
approved these changes
Feb 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a
panic()while scanning a target in GrabBanner, trap it and log the target to the standard logger at the ERROR level, before re-throwing the panic.How to Test
There is no place place that intentionally panics, so I have been testing by adding a panic() call to e.g.
Scan@modules/ftp.go.Notes & Caveats
This arose from debugging https://ichnaea.eecs.umich.edu/admin/tasks/a47e2ae2-4f47-4ae4-86da-b8cc3a85a5c9 -- since the code panicked, the IP address did not get written to the output. We don't log the IP in non-panic cases since in those cases, the IP address should be available in the output.
Issue Tracking
Re https://trello.com/c/CcL2qo60/1191-zgrab-https-scan-segfault, which was fixed by zmap/zcrypto#107.