Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLD removal auto-pr missing for "shriram" #512

Closed
ezekiel opened this issue Nov 30, 2020 · 5 comments
Closed

TLD removal auto-pr missing for "shriram" #512

ezekiel opened this issue Nov 30, 2020 · 5 comments
Assignees
Labels

Comments

@ezekiel
Copy link
Contributor

ezekiel commented Nov 30, 2020

"shriram" has a removal date of 2020-11-24. Likely that @tld-update-bot just needs a nudge?

@cpu cpu self-assigned this Nov 30, 2020
@cpu
Copy link
Member

cpu commented Nov 30, 2020

@ezekiel hey there :-) 👋

Thanks for flagging. I took a peek at the automation Travis and I think the last build was ~7d ago which would explain a missing update from the 24th of Nov. There's a few problems with the Travis automation:

  • The Travis integration somehow got disabled (???) and I had to click a button to re-enable. That should be fixed now.
  • The build I kicked off was broken because it uses HEAD of master w/ a v2 path and fe65bae moved the zlint-tld-update script. I fixed this in master.
  • Travis is lagging, or not picking up the new commit. I can't seem to trigger a build with the fix for the v3 tool path.

Bitrot comes for us all.

I already have a Github Action based version of this automation written up for #507 that worked successfully last night in my test repo.

After work today I'll open a PR to get ZLint switched to using that integration instead of the Travis one. I think that's the quickest way to get this fixed if Travis doesn't queue a fixed build soon.

@cpu cpu added the bug label Nov 30, 2020
@cpu
Copy link
Member

cpu commented Nov 30, 2020

I think that's the quickest way to get this fixed if Travis doesn't queue a fixed build soon.

(Or I could stamp a one-off manually created PR for this fix if it's important to land in <12-24hr)

@ezekiel
Copy link
Contributor Author

ezekiel commented Nov 30, 2020

👋 hello!

Please take your time, no urgency from me for merging. Happy to wait and to see things ironed out. Thank you!

@cpu
Copy link
Member

cpu commented Nov 30, 2020

After work today I'll open a PR to get ZLint switched to using that integration instead of the Travis one.

#513 - once this is merged we should see a PR with the shriram removal update in <1hr.

@cpu
Copy link
Member

cpu commented Nov 30, 2020

Resolved by #514

We have a couple little things to sort out with the new automation but it should be reliable enough now to get regular updates again. Will monitor.

@cpu cpu closed this as completed Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants