CI: Add cron workflow for gTLD update PRs, deprecate tld-update-bot. #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we used a separate repo with a bash script[0] hooked up to a bot github user[1] in a Travis CI cron build to automatically create PRs updating ZLint TLD data on a periodic basis. Now that we're using Github Actions we can make things much simpler and self-contained. This commit adds a `tld-update.yml` workflow that uses a create-pull-request Github action to replace the separate repo/bash script/bot user approach. Not only does this let us delete the bot user's write access to the ZLint repo but it's also a smarter integration overall and won't recreate the same PR over and over if it isn't merged right away. Lastly the Github Actions cron schedule is more flexible so we can run the new action once every hour instead of just once a day like the Travis version. [0]: https://github.com/cpu/zlint-autopull/blob/master/autopull [1]: https://github.com/tld-update-bot [2]: https://github.com/peter-evans/create-pull-request
zakird
reviewed
Nov 30, 2020
zakird
approved these changes
Nov 30, 2020
|
I removed @tld-update-bot's access to the ZLint repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we used a separate repo with a bash script hooked up to a bot github user in a Travis CI cron build to automatically create PRs updating ZLint TLD data on a periodic basis using the
zlint-gtld-updatetool from this repo. Recently it's been having reliability issues that made us miss a TLD update: #512Now that we're using Github Actions we can make things much simpler and self-contained. This commit adds a
tld-update.ymlworkflow that uses a create-pull-request Github action to replace the separate repo/bash script/bot user approach.Resolves #507
Notable Improvements
Testing
To test the integration I pushed a commit to a fork of ZLint that removed some of the gTLD map data. Afterwards I updated the action to run on push of a specific test branch in addition to the cron schedule. Pushing that test branch resulted in a correct automation PR being opened to add back the removed data (and the missed update from #512). You can see the PR that was opened here. No bot account or bash scripts required 馃帀