Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update newLint.sh script and contributing guide. #397

Merged
merged 4 commits into from
Feb 13, 2020
Merged

Update newLint.sh script and contributing guide. #397

merged 4 commits into from
Feb 13, 2020

Conversation

pkoro
Copy link
Contributor

@pkoro pkoro commented Feb 13, 2020

@zakird zakird requested a review from cpu February 13, 2020 16:59
cpu
cpu requested changes Feb 13, 2020
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pkoro I appreciate you picking this up! I left some small feedback.

newLint.sh Outdated Show resolved Hide resolved
template Show resolved Hide resolved
newLint.sh Outdated Show resolved Hide resolved
cpu
cpu approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pkoro, LGTM.

@cpu cpu merged commit 53441bd into zmap:master Feb 13, 2020
@cpu cpu mentioned this pull request Feb 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkoro @cpu