Move EV-specific tests to cabf_ev

[sleevi]

This moves the lints for the EV Guidelines into cabf_ev, ensuring a consistent sourcing and reference.

Closes #439

[sleevi]

@cpu My first request here, so let me know if I've botched anything here.

I realize this does "two things, not one" - in that in the process of moving, it aligns everything to use "EVGs" to match the "BRs" reference of the existing lints. Happy to pull that into a separate PR, if useful, or to update the description to better reflect that.

[cardonator]

Personally, I think this is quite grokable and there is no need for a second PR. 👍

It does make me wonder why we have the Baseline Requirements and the EV Guidelines. Are the EVGs the Pirate's code? 😄

[cpu]

I realize this does "two things, not one" - in that in the process of moving, it aligns everything to use "EVGs" to match the "BRs" reference of the existing lints. Happy to pull that into a separate PR, if useful, or to update the description to better reflect that.

No worries, I don't think it makes this hard to review to have both things done at once 👍 Thanks for the PR!

[cpu]

The diff here looks good to me. Thanks @sleevi!

One strange thing is the integration test failure:

TestCorpus: corpus_test.go:163: expected lint "e_ev_valid_time_too_long" to have result fatals: 0    errs: 0    warns: 0    infos: 0    got fatals: 0    errs: 5    warns: 0    infos: 0   

It looks like prev. integration tests weren't expecting any findings for this lint and now there are 5 error results. I can't immediately spot a reason for this but suspect it's something silly. Can you update the integration/config.json so this will pass (and maybe see if the new 5 err results make sense?).

[sleevi]

Yup, that’s what lead to #446 , as this is odd and I do want to dive in before just tweaking tests blindly :)

[sleevi]

@cpu The failure was due to #447 , so I've rebased and updated that PR (still used to Chromium's rebase-based workflow, versus GitHub's seeming preference for a merge workflow, so apologies if I've stuffed up)

The CI should be nice and happy ("it works on my machine")

Problem has been resolved, tests are now passing.

[cpu]

Thanks!