Update apple 398 cert validity cert to not apply to CA certs #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleevi
approved these changes
Jul 22, 2020
cpu
reviewed
Jul 22, 2020
| @@ -29,7 +29,7 @@ func (l *serverCertValidityTooLong) Initialize() error { | |||
| } | |||
|
|
|||
| func (l *serverCertValidityTooLong) CheckApplies(c *x509.Certificate) bool { | |||
| return util.IsServerAuthCert(c) | |||
| return util.IsServerAuthCert(c) && !c.IsCA | |||
There was a problem hiding this comment.
@cardonator This should really have a unit test to prevent a regression.
There was a problem hiding this comment.
Good call, I will get a PR in for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, noticed that the Apple lint is applying to certs marked with the CA basic constraint so added a quick boolean check to confirm. We also double checked with Clint to make sure Apple wasn't intending to apply their policy to CA certs :)