Fix for pull request #479 #599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Error handling for invalidKUs. This fixes pull request zmap#479.
cpu
requested changes
May 13, 2021
There was a problem hiding this comment.
Hi @ENEN-DTR, thanks for fixing up this PR.
I haven't looked at the substance of the code yet but there are a handful of things that will need to be fixed before it can be merged:
-
The testdata lint stage is failing: double check you have the OpenSSL textual headers on all the
.pemfiles you're adding in this branch -
The golangci-lint stage is failing: double check that everything is
gofmt-ed with-s -
The integration test stage is failing: double check the
config.jsonupdate.
Hope that helps,
|
@christopher-henderson or @ENEN-DTR can you close this PR since the fix was included in #678 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Error handling for invalidKUs.
This fixes pull request #479.