Forbid wildcard certs for non .onion EVs #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakird
approved these changes
Oct 16, 2021
sleevi
approved these changes
Oct 16, 2021
| } | ||
|
|
||
| func (l *EvNotWildCard) Execute(c *x509.Certificate) *lint.LintResult { | ||
| names := append(c.GetParsedDNSNames(false), c.GetParsedSubjectCommonName(false)) |
There was a problem hiding this comment.
Do you need to add the subject common name here, given it should be a name in the DNS names? I thought I understood your remarks on the other PR to be that it’s reasonable to ignore/skip adding.
There was a problem hiding this comment.
Which one? Not the case sensitivity one? My only point there was that the casing of the input into ToUnicode does indeed affect it's output and not anything to do specifically with the case insensitivity of DNS in general (but you must mean a different review because I can't see the relation to this one).
There was a problem hiding this comment.
Oops, sorry, that was BJ and Corey - #635 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lint implements
CABF EV Guidelines 1.7.8 Section 9.8.1which states that...The one corpus certificate that was an error was this Camerfirma certificate which is indeed an EV wildcard.
This change address #634 as reported by @mimi89999.