test.ReadTestCert breaks for downstream consumers dependent on the previous relative certificate path building behavior #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopher-henderson
changed the title
christopher-henderson
changed the title
christopher-henderson
force-pushed
the
reverttestpath
branch
from
13bcf2d
to
f39db55
Compare
zakird
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change was made in e5ee614#diff-47c0d21c7e2125d3727429db1028c23a261ce73c25250dc176cb68bf666d7a23L73 wherein the path to find test certificates was changed to be absolute from the root of the repo.
This made it easier to run the tests from any location in the repo, however it broke some downstream consumers who were dependent upon this relative path construction.
Fixes #696