Duplicate lints about keyIdentifier in certificates #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakird
approved these changes
Jun 11, 2023
mtgag
reviewed
Jun 13, 2023
| @@ -57,7 +59,23 @@ func (l *authorityKeyIdNoKeyIdField) CheckApplies(c *x509.Certificate) bool { | |||
| } | |||
|
|
|||
| func (l *authorityKeyIdNoKeyIdField) Execute(c *x509.Certificate) *lint.LintResult { | |||
| if c.AuthorityKeyId == nil && !util.IsSelfSigned(c) { //will be nil by default if not found in x509.parseCert | |||
| if util.IsCACert(c) && util.IsSelfSigned(c) { | |||
There was a problem hiding this comment.
Maybe we can remove util.IsCACert(c)? Only if it is self-signed it may be omitted.
There was a problem hiding this comment.
I'm not quite convinced of that based on the language.
There is one exception; where a CA distributes its public key in the form of a "self-signed" certificate, the authority key identifier MAY be omitted.
It seems to me that this clause is stating that this does apply, specifically to CA certs and not just to any self signed.
Although what exists in practice may of course differ.
mtgag
reviewed
Jun 13, 2023
v3/lints/rfc/lint_ext_authority_key_identifier_no_key_identifier.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mtgag to bring this review to your attention.
Removes a duplicate lint regarding RFC 5280: 4.2.1.1.
Additionally, I believe that the lint itself was slightly inaccurate vis-a-vis RFC 5280.
I've attempted to encode this language a bit more precisely in this lint update.
Integration Test Failures
I'm working through smoke checking these fingerprints, but so far it looks reasonable.
For example, fe716ff3996cd6561b6b63a8c440fdf5489cf48f7834283eebd19b380f3fbc22 features a certificate that is indeed a CA, but is not self signed and does not have the authority key id (well, it has the common name and serial, but not the actual identifier).
Addresses #725