Include LintMetadata in the LintResult #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaomidi
changed the title
dadrian
reviewed
Aug 1, 2023
|
I didn't really think about if we want it in JSON or not when writing this and was following the rest of the fields. No opinions on it either way and I'm happy to exclude it from JSON serialization. I don't see harm in this being included though either as the metadata is effectively only a bunch of strings. |
|
I think the JSON output would be extremely redundant when ran with ZCertificate if LintMetadata was included, so let's leave it out of the JSON. |
dadrian
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the need to do a lookback on what the lint was based on its name when all the user needs is the metadata.
This also allows the name field in the results to be eventually sunset.