Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent fingerprinting ZMap by randomizing the IP ID #798
Prevent fingerprinting ZMap by randomizing the IP ID #798
Changes from 4 commits
fcc944a
56e7e1c
e3ddb30
1fe02a6
8a003d3
7deef97
3ffa581
92d5301
7daf355
46fac21
9d21c7c
0ec026f
3d49223
d799e20
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to make sure here that we're not passing in the same entropy that's passed in from the
uint32_t *validation
parameter. It might make sense to pass in IPID directly too since that's more tightly typed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair, I've moved to only generating the
ip_id
insend.c
here and passing it directly in.Also, I changed to using
random_bytes
which reads from/dev/urandom
, should be completely distinct from any other RNG in our code.