Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate lua-resty-session to v4 #464

Open
pankgeorg opened this issue Feb 6, 2023 · 2 comments · May be fixed by #478
Open

Migrate lua-resty-session to v4 #464

pankgeorg opened this issue Feb 6, 2023 · 2 comments · May be fixed by #478

Comments

@pankgeorg
Copy link

pankgeorg commented Feb 6, 2023

I've found this nice PR where the author of lua-resty-session bumps the usage of the library to v4.

https://github.com/Kong/kong/pull/10199/files

We've had our fair share of problems with cookies in the v3 version (some of them are in open issues), and while it's hard to trust a codebase that is two weeks old, it's scary not to trust it too.

What do you think about making the migration? Is that something aligned with the project goals? I could potentially also find time in the next 3 months, if the consensus is that it will work better.

@bodewig
Copy link
Collaborator

bodewig commented Feb 8, 2023

Given that we just found lua-resty-session 4 breaks backwards compatibility the hard way - see #463 - I guess we will want to migrate to it eventually. Personally I haven't followed the development "over there" and can not judge whether 4.x is "better" for any kind of better - but it is going to be the version that is under active development and receives bug fixes in the future.

@balajiv113
Copy link

Any updates on this ??

If contributions are welcome am happy to take this and provide support for lua-resty-session 4.x

@balajiv113 balajiv113 linked a pull request Apr 28, 2023 that will close this issue
thomasleplus added a commit to leplusorg/openid-connect-provider-debugger that referenced this issue May 6, 2024
opm install the latest version of lua-resty-session which has compatibility issues with lua-resty-openidc (see zmartzone/lua-resty-openidc#464) and lua-resty-openidc documentation now states that opm is no longer supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants