Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow client creation from authorizing HTTP client #123

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

CodyDWJones
Copy link
Contributor

This change allows apps to supply a http.Client they already have, rather than relying on the Authenticator helper. An app might use common code to obtain an auth'd http.Client because it interacts with many OAuth services.

@CodyDWJones
Copy link
Contributor Author

I didn't realize #107 had been submitted. Either approach satisfies my requirement. #107 is more future proof (if a non-exported field is added to Client) but until then quite a bit more verbose.

@zmb3
Copy link
Owner

zmb3 commented Apr 22, 2020

Thanks for this, #107 is probably a nicer approach, but this is 100% backwards compatible so I'll merge this and we'll keep #107 around in case somebody wants to work on a v2 of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants