Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit with ruff + black #30

Closed
zmievsa opened this issue Sep 10, 2023 · 5 comments
Closed

Add pre-commit with ruff + black #30

zmievsa opened this issue Sep 10, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@zmievsa
Copy link
Owner

zmievsa commented Sep 10, 2023

No description provided.

@Aditi840
Copy link

@Ovsyanka83, I would like to work on this issue, just give me an overview on what needs to be done.

@zmievsa
Copy link
Owner Author

zmievsa commented Sep 11, 2023

We need to add a pre-commit file that will run ruff and black.

Note that both must use configurations from project.toml.

Let's leave out pyright for now. We'll just add it as a separate step in CI later because there are many issues with running it at pre-commit.

@zmievsa zmievsa changed the title Add pre-commit with ruff + black + pyright Add pre-commit with ruff + black Sep 11, 2023
zmievsa pushed a commit that referenced this issue Sep 11, 2023
@zmievsa
Copy link
Owner Author

zmievsa commented Sep 11, 2023

I'm afraid @coffeewasmyidea did this much faster. I hope it's okay with you.

@zmievsa zmievsa closed this as completed Sep 11, 2023
@Aditi840
Copy link

@Ovsyanka83, It's fine, let me know if you need help in another issue.

@zmievsa
Copy link
Owner Author

zmievsa commented Sep 15, 2023

@Aditi840 Oh I always do, thanks!
You can start out with these issues and then move on to the more complex ones once you familiarize yourself with the code base.

There's also the linked issue that is closely related to this one :)

So there are plenty of coding, documentation, testing, and infrastructural tasks. If you want something more researchy, we also have the two milestones that require research, planning, and a lot of coding as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants