Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more units for convenience #4

Open
zmitchell opened this issue Jun 1, 2019 · 0 comments
Open

Add more units for convenience #4

zmitchell opened this issue Jun 1, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@zmitchell
Copy link
Owner

Currently you can only specify the units of an angle in degrees or radians. No one in the history of the universe has ever said "the angle is 1.5705 radians," but plenty of people have said "the angle is pi/2." To make describing angles more natural, it makes sense to allow the user to specify angles in units of pi. This is how that would look:

# defining an angle of pi/2
angle = 0.5
angle_units = "pi"

Another instance of this awkwardness is when you define the retardation of an optical retarder (phase plate). It would be natural to say that the retarder has a delay of some fraction of a wavelength, so adding a wavelengths unit would also be a quality of life improvement.

@zmitchell zmitchell added enhancement New feature or request good first issue Good for newcomers labels Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant