bugfix(combos): hold-taps must observe released combo events

app/src/behaviors/behavior_combo.c

@@ -232,7 +232,7 @@ static void release_pressed_keys() {
         }
         struct position_state_changed *captured_event = pressed_keys[i];
         pressed_keys[i] = NULL;
-        ZMK_EVENT_RAISE_AT(captured_event, behavior_combo);
+        ZMK_EVENT_RAISE(captured_event);
     }
 }
 

app/tests/combo/combos-and-holdtaps-2/events.patterns

@@ -0,0 +1,2 @@
+s/.*hid_listener_keycode_//p
+s/.*combo//p

app/tests/combo/combos-and-holdtaps-2/keycode_events.snapshot

@@ -0,0 +1,2 @@
+pressed: usage_page 0x07 keycode 0xe0 mods 0x00
+pressed: usage_page 0x07 keycode 0xe4 mods 0x00

app/tests/combo/combos-and-holdtaps-2/native_posix.keymap

@@ -0,0 +1,48 @@
+#include <dt-bindings/zmk/keys.h>
+#include <behaviors.dtsi>
+#include <dt-bindings/zmk/kscan-mock.h>
+
+&mt {
+	flavor = "hold-preferred";
+};
+
+/* This test verifies that hold-tap keys can observe
+ * events which were released from combos.
+ */
+/ {
+	behaviors {
+		combo_one {
+			compatible = "zmk,behavior-combo";
+			label = "COMBO_ONE";
+			timeout-ms = <100>;
+			key-positions = <0 2>;
+			bindings = <&kp Y>;
+		};
+		combo_two {
+			compatible = "zmk,behavior-combo";
+			label = "COMBO_TWO";
+			timeout-ms = <100>;
+			key-positions = <1 3>;
+			bindings = <&kp Z>;
+		};
+	};
+
+	keymap {
+		compatible = "zmk,keymap";
+		label ="Default keymap";
+
+		default_layer {
+			bindings = <
+				&mt LEFT_CONTROL A &mt RIGHT_CONTROL B
+				&none &none
+			>;
+		};
+	};
+};
+
+&kscan {
+	events = <
+		ZMK_MOCK_PRESS(0,0,0) 
+		ZMK_MOCK_PRESS(0,1,300)
+	>;
+};