Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits and improvements to the reusable build workflow #1258

Merged

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Apr 22, 2022

  • Add artifact_name as a workflow dispatch option. Users can specify a different output artifact name alongside custom build and config path.
  • Use set -x for verbose output of shell commands. This will display content of all environment variables and aid troubleshooting.
  • Simplify grep one-liner command for displaying Kconfig file.
  • Steps naming consistency.
  • Shell if then statement consistency.

Copy link
Collaborator

@joelspadin joelspadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@filterpaper filterpaper force-pushed the reusable-workflow-artifactname branch from 29eea62 to 30b18d0 Compare May 12, 2022 01:59
@filterpaper filterpaper changed the title Add custom artifact name to reusable build workflow Edits and improvements to the reusable build workflow May 12, 2022
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit 2e89ca0 into zmkfirmware:main May 18, 2022
@filterpaper filterpaper deleted the reusable-workflow-artifactname branch May 18, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants