Kscan cleanup #1269
Merged
Kscan cleanup #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key scanning drivers are now automatically enabled when a DT node with the matching "compatible" property is present and enabled, so they no longer need to be manually set for each board.
|
I've tested this on a board that uses the composite, matrix, and direct GPIO drivers. I don't have anything that uses the demux driver though. |
petejohanson
approved these changes
Apr 26, 2022
kurtis-lew
added a commit
to kurtis-lew/zmk
that referenced
this pull request
May 2, 2022
Updated behaviors to use Kconfig preprocessor functions similarly to zmkfirmware#1269. https://docs.zephyrproject.org/latest/build/kconfig/preprocessor-functions.html
kurtis-lew
added a commit
to kurtis-lew/zmk
that referenced
this pull request
May 2, 2022
Updated behaviors to use Kconfig preprocessor functions similarly to zmkfirmware#1269. https://docs.zephyrproject.org/latest/build/kconfig/preprocessor-functions.html
kurtis-lew
added a commit
to kurtis-lew/zmk
that referenced
this pull request
May 2, 2022
Updated behaviors to use Kconfig preprocessor functions similarly to zmkfirmware#1269. https://docs.zephyrproject.org/latest/build/kconfig/preprocessor-functions.html
kurtis-lew
added a commit
to kurtis-lew/zmk
that referenced
this pull request
May 3, 2022
…or Functions Updates behaviors to compile only those explicitly used in a keymap, similarly to zmkfirmware#1269.
kurtis-lew
added a commit
to kurtis-lew/zmk
that referenced
this pull request
May 3, 2022
…or Functions Updates behaviors to compile only those explicitly used in a keymap, similarly to zmkfirmware#1269.
4 tasks
kurtis-lew
added a commit
to kurtis-lew/zmk
that referenced
this pull request
Jun 12, 2022
…or Functions Updates behaviors to compile only those explicitly used in a keymap, similarly to zmkfirmware#1269.
kurtis-lew
added a commit
to kurtis-lew/zmk
that referenced
this pull request
Jun 18, 2022
Updates behaviors to compile only those explicitly used in a keymap, similarly to zmkfirmware#1269.
kurtis-lew
added a commit
to kurtis-lew/zmk
that referenced
this pull request
Jun 18, 2022
Updates behaviors to compile only those explicitly used in a keymap, similarly to zmkfirmware#1269.
kurtis-lew
added a commit
to kurtis-lew/zmk
that referenced
this pull request
Jun 18, 2022
Updates behaviors to compile only those explicitly used in a keymap, similarly to zmkfirmware#1269.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched the matrix kscan driver over to use the GPIO DT spec macros and updated Kconfig to automatically enable each driver based on DT nodes.
I didn't update the direct and demux drivers similarly because those are still defining functions with macros, and I figured it would be a lot easier to review as separate PRs that align them with how the matrix driver now works.